Re: Logical replication CPU-bound with TRUNCATE/DROP/CREATE many tables

On Mon, Sep 28, 2020 at 2:22 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Mon, Sep 28, 2020 at 10:01 AM Keisuke Kuroda
> <keisuke(dot)kuroda(dot)3862(at)gmail(dot)com> wrote:
> >
> > > Okay. Feel free to clarify your questions if you have any? Are you
> > > interested in writing a patch for the same?
> >
> > Thank you! Yes, I would like to write a patch.
> > If you already have a discussed thread or patch for this idea,
> > please let me know.
> >
>
> I don't have a patch for this idea but you can refer [1]
> (v25-0002-Issue-individual-invalidations-with-wal_level-lo) to see
> what I was trying to say about registering the invalidations in the
> form of ReorderBufferChange. We have something along the lines of what
> I described above in that patch but we have removed it because we need
> all the invalidations to be accumulated to handle aborts and we don't
> want two different mechanisms to store invalidations.

In some of the intermediate version of the logical-decoding, we had
collected in form of changes and later we changed it so that we can
execute all the invalidation on abort. I just browsed old patch and
fetch the changes to collect the invalidation in form of changes. I
have rebased on the current head so that we collect both in form of
changes as well as collection of the invalidation. So if we get
individiaual invalidation we execute them and on abort we execute all
the invalidation together.

--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com