Re: make ExecInsertIndexTuples arguments less bad

From: Fabrízio de Royes Mello <fabriziomello(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: make ExecInsertIndexTuples arguments less bad
Date: 2026-02-11 19:29:33
Message-ID: CAFcNs+pX-bjb80_g_oMwbdrWa9vT+Ke7n7qCMETXPghSwugbJg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Feb 11, 2026 at 4:07 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:

> Hello,
>
> The arguments to ExecInsertIndexTuples() are rather unhelpful to read;
> patching them is messy and hard to follow. How about we reuse the
> pattern we used in commit f831d4accda0 to make them less bad?
> I think the code is much nicer to read this way.
>
>
Much better. LGTM!

--
Fabrízio de Royes Mello

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2026-02-11 19:30:21 Re: Improve OAuth discovery logging
Previous Message Zsolt Parragi 2026-02-11 19:24:14 Improve OAuth discovery logging