make ExecInsertIndexTuples arguments less bad

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: make ExecInsertIndexTuples arguments less bad
Date: 2026-02-11 19:07:39
Message-ID: 202602111846.xpvuccb3inbx@alvherre.pgsql
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello,

The arguments to ExecInsertIndexTuples() are rather unhelpful to read;
patching them is messy and hard to follow. How about we reuse the
pattern we used in commit f831d4accda0 to make them less bad?
I think the code is much nicer to read this way.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"If you have nothing to say, maybe you need just the right tool to help you
not say it." (New York Times, about Microsoft PowerPoint)

Attachment Content-Type Size
0001-Split-out-ExecInsertIndexTuples-arguments.patch text/x-diff 12.2 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zsolt Parragi 2026-02-11 19:24:14 Improve OAuth discovery logging
Previous Message Paul A Jungwirth 2026-02-11 18:50:49 Re: domain for WITHOUT OVERLAPS