| From: | Matthew Kleiman <mkleiman(at)pivotal(dot)io> |
|---|---|
| To: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Cc: | Sarah McAlear <smcalear(at)pivotal(dot)io> |
| Subject: | [pgAdmin4] To Extract or Not To Extract - That is the Question |
| Date: | 2017-06-01 14:15:41 |
| Message-ID: | CAFS4TJb-7VTQQrnOi0g6MaoxMfEK9LzCds2yG+ByS-mLHwydQA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi Hackers!
We noticed that there have been quite a few Redmine issues that ended up
being related to the same function in sqleditor.js. We were wondering if it
might be a good idea to extract this function and test it. This would allow
us to iterate more quickly and identify potential bugs before they're
opened. There have been a few merge conflicts already in this area and
without tests it is difficult to resolve these with high confidence.
The function in question is the callback for onSelectedRangesChanged. In
the latest commit on master (12fa02), it's from line 696 to 773.
[image: Inline image 1]
Thoughts?
Best,
Sarah & Matt
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Eckhardt | 2017-06-01 14:52:00 | Re: [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience |
| Previous Message | Murtuza Zabuawala | 2017-06-01 13:06:28 | Re: [pgAdmin4][Patch]: Fixed RM 2324 - PostGIS datatypes not showing up properly on SQL tab. |