| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Matthew Kleiman <mkleiman(at)pivotal(dot)io> |
| Cc: | pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>, Sarah McAlear <smcalear(at)pivotal(dot)io> |
| Subject: | Re: [pgAdmin4] To Extract or Not To Extract - That is the Question |
| Date: | 2017-06-01 15:11:56 |
| Message-ID: | CA+OCxoxfAT5CavRZVT=ET9NBT5Lw4YU6qp4cVVxjnwOYZx6eXw@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Thu, Jun 1, 2017 at 3:15 PM, Matthew Kleiman <mkleiman(at)pivotal(dot)io> wrote:
> Hi Hackers!
>
> We noticed that there have been quite a few Redmine issues that ended up
> being related to the same function in sqleditor.js. We were wondering if
> it might be a good idea to extract this function and test it. This would
> allow us to iterate more quickly and identify potential bugs before they're
> opened. There have been a few merge conflicts already in this area and
> without tests it is difficult to resolve these with high confidence.
>
> The function in question is the callback for onSelectedRangesChanged. In
> the latest commit on master (12fa02), it's from line 696 to 773.
>
> [image: Inline image 1]
>
>
Sounds sensible. Do you have a proposed patch?
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Surinder Kumar | 2017-06-01 15:13:02 | Re: [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience |
| Previous Message | Robert Eckhardt | 2017-06-01 14:52:00 | Re: [pgAdmin4][PATCH] Improvements to Query Results Grid User Experience |