| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Make the logical replication conflict messages more like each other |
| Date: | 2026-09-08 05:09:23 |
| Message-ID: | CAFPTHDbyfakoemuL5=BPPh867tSdAbivP0Z1hfW0JtnQQ9Cadg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, May 19, 2026 at 9:08 AM Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> Hi,
>
> (This was first suggested by me in thread [1], but it was deemed out
> of scope, so I have now separated it here.)
>
> I was looking at the many messages related to logical replication
> conflicts (in conflict.c, function errdetail_apply_conflict).
> Currently, the wording for the errmsgdetail seems a bit inconsistent
> to me. I felt that because all of these messages are closely related,
> they should all resemble each other more than they do now.
>
> ~~~
Hi Peter,
Just want to +1 the general idea here. Consistency across these
conflict messages is worth caring about - it helps users pattern-match
on wording in logs. It also makes it easier for whoever adds a new
conflict type later to slot into an existing style rather than
drifting further apart.
regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-09-08 05:11:20 | Re: Revert RI fast-path batching from REL_19_STABLE |
| Previous Message | Henson Choi | 2026-09-08 05:08:10 | Re: Row pattern recognition |