| From: | Henson Choi <assam258(at)gmail(dot)com> |
|---|---|
| To: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
| Cc: | jian(dot)universality(at)gmail(dot)com, zsolt(dot)parragi(at)percona(dot)com, sjjang112233(at)gmail(dot)com, vik(at)postgresfriends(dot)org, er(at)xs4all(dot)nl, jacob(dot)champion(at)enterprisedb(dot)com, david(dot)g(dot)johnston(at)gmail(dot)com, peter(at)eisentraut(dot)org, li(dot)evan(dot)chao(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Row pattern recognition |
| Date: | 2026-09-08 05:08:10 |
| Message-ID: | CAAAe_zCxQqzcQQjat1MD3OPOtsD7sdkFTEt3rqNk8ntErt3s7Q@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tatsuo,
> execRPR.c:1361:14: error: unused variable 'pattern'
[-Werror,-Wunused-variable]
> 1361 | RPRPattern *pattern = winstate->rpPattern;
> | ^~~~~~~
That is nfa_advance_var()'s local. Only an Assert reads it, so a
build without --enable-cassert leaves it unused. Our own builds all
have cassert on, which is why it never showed up locally.
In the increment, nocfbot-2013-executor-reads-own-state.txt drops the
local and has the Assert read winstate->rpPattern directly:
Assert(elem->next >= 0 &&
elem->next < winstate->rpPattern->numElements);
It is an error that arose partway through the increment, so fixing it
is right. 2013 settles it.
From here on I will run the build and the tests against a release
build as well.
Best regards,
Henson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ajin Cherian | 2026-09-08 05:09:23 | Re: Make the logical replication conflict messages more like each other |
| Previous Message | Wataru Naotsuka | 2026-09-08 04:49:17 | Authorization semantics and candidate pruning in GRAPH_TABLE |