Re: [PATCH] Preserve replication origin OIDs in pg_upgrade

From: Ajin Cherian <itsajin(at)gmail(dot)com>
To: Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Rui Zhao <zhaorui126(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com>
Subject: Re: [PATCH] Preserve replication origin OIDs in pg_upgrade
Date: 2026-11-17 23:48:01
Message-ID: CAFPTHDbVf1tTb67Ae=AOQNmf976ppBXeyqomg3LpTUjVp5SRMg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 17, 2026 at 6:36 AM Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> wrote:
>
> Hello
>
> I think the old cluster issue still exists eveen with v22/23, as
> pointed out by claude:
>
> Set up a PG15 subscriber with an enabled subscription, with its table
> in state i at clean shutdown, 50 extra databases (to make the check
> phase longer), and pre_auth_delay=1 on the publisher to simulate a
> slow connection.
>

Thanks, I’ve reproduced both cases with a PG15 subscriber.

The cause is that pg_upgrade starts the old cluster with -b, which
only disables the logical replication launcher from PG17 onward. On
older clusters, tablesync workers run while pg_upgrade is checking and
dumping.

v24 (attached) starts pre-17 old clusters with -c
max_logical_replication_workers=0. With that, neither case reproduces
from PG10 or PG15.

Regards,
Ajin Cherian
Fujitsu Australia

Attachment Content-Type Size
v24-0002-Preserve-replication-origin-IDs-during-pg_upgrad.patch application/octet-stream 48.4 KB
v24-0001-Preserve-subscription-OIDs-during-pg_upgrade.patch application/octet-stream 10.2 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ajin Cherian 2026-11-18 01:12:07 Re: Initial table sync copies the whole table when it is no longer published
Previous Message Jonah Shafran 2026-11-17 23:39:23 Re: ISBN range table