| From: | Zsolt Parragi <zsolt(dot)parragi(at)percona(dot)com> |
|---|---|
| To: | Ajin Cherian <itsajin(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Rui Zhao <zhaorui126(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, Shlok Kyal <shlok(dot)kyal(dot)oss(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Subject: | Re: [PATCH] Preserve replication origin OIDs in pg_upgrade |
| Date: | 2026-11-16 19:36:32 |
| Message-ID: | CAN4CZFPPbUPDQtpaz4Hhjtaw+L_3RV-7bKcRju0yXSwhn3SatA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
I think the old cluster issue still exists eveen with v22/23, as
pointed out by claude:
Set up a PG15 subscriber with an enabled subscription, with its table
in state i at clean shutdown, 50 extra databases (to make the check
phase longer), and pre_auth_delay=1 on the publisher to simulate a
slow connection.
And then pg_upgrade from v23:
Checking subscription state ok
...
-- pg_upgrade_dump_globals.sql:
SELECT pg_catalog.binary_upgrade_create_replication_origin('2'::pg_catalog.oid,
'pg_16391_16384'::pg_catalog.text, '0/40466F8'::pg_catalog.pg_lsn);
-- new cluster, after DROP SUBSCRIPTION s:
2 | pg_16391_16384
With the default timing the opposite happens: the tablesync starts
before the check, and pg_upgrade fails with 'The table sync state "d"
is not allowed', even though the table was in state i when the cluster
was stopped. The TAP test doesn't see either case because it sets
max_logical_replication_workers = 0 on the old subscriber.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zsolt Parragi | 2026-11-16 19:46:18 | Re: pg_regress: schedule multi-line test groups |
| Previous Message | Greg Lamberson | 2026-11-16 19:36:00 | Re: Extensible sync handler registration (register_sync_handler) |