| From: | Ajin Cherian <itsajin(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] logical decoding of two-phase transactions |
| Date: | 2020-09-21 11:52:20 |
| Message-ID: | CAFPTHDaPz015SAVY1HikSph0A2XC=nVPTPh_7fW-=So1dx_+3Q@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 21, 2020 at 9:24 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> I think we need to call ReorderBufferAbort at least to clean up the
> TXN. Also, if what you are saying is correct then that should be true
> without this patch as well, no? If so, we don't need to worry about it
> as far as this patch is concerned.
Yes, that is true. So will change this check to:
if (TransactionIdIsValid(xid) &&
ReorderBufferTxnIsPrepared(ctx->reorder, xid, parsed->twophase_gid)
regards,
Ajin Cherian
Fujitsu Australia
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bharath Rupireddy | 2020-09-21 11:52:25 | Re: make MaxBackends available in _PG_init |
| Previous Message | Ranier Vilela | 2020-09-21 11:32:35 | Re: Planner, check if can use consider HASH for groupings (src/backend/optimizer/plan/planner.c) |