Re: Patch: Implement failover on libpq connect level.

From: Christopher Browne <cbbrowne(at)gmail(dot)com>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: PostgreSQL Mailing Lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: Implement failover on libpq connect level.
Date: 2015-10-26 21:02:17
Message-ID: CAFNqd5XXk+E+qxaNtB04RBpCQigUF=z0EJWDmUHpT0qMuM15SQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-jdbc

On 26 October 2015 at 16:25, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:

> On 10/14/15 6:41 AM, Victor Wagner wrote:
> > 1. It is allowed to specify several hosts in the connect string, either
> > in URL-style (separated by comma) or in param=value form (several host
> > parameters).
>
> I'm not fond of having URLs that are not valid URLs according to the
> applicable standards. Because then they can't be parsed or composed by
> standard libraries.
>
> Also, this assumes that all the components other than host and port are
> the same. Earlier there was a discussion about why the ports would ever
> need to be different. Well, why can't the database names be different?
> I could have use for that.
>
> I think you should just accept multiple URLs.
>

I'd give a "+1" on this...

As an area of new behaviour, I don't see a big problem with declining to
support every wee bit of libpq configuration, and instead requiring the
use of URLs.

Trying to put "multiplicities" into each parameter (and then considering
it at the pg_service level, too) is WAY more complicated, and for a
feature where it seems to me that it is pretty reasonable to have a
series of fully qualified URLs.

Specifying several URLs should be easier to understand, easier to
test, easier to code, and easier to keep from blowing up badly.

I'll observe that this is the way that OpenLDAP supports specifying
multiple clients, so this technique is familiar in other contexts
where people are trying to accomplish the same kind of thing.
Sample docs, perhaps not authoritative, but useful enough...
<http://manpages.courier-mta.org/htmlman5/ldap.conf.5.html>
--
When confronted by a difficult problem, solve it by reducing it to the
question, "How would the Lone Ranger handle this?"

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message fortin.christian 2015-10-26 21:39:44 Re : Re: [HACKERS] UTF-32 support in PostgreSQL ?
Previous Message Andrew Dunstan 2015-10-26 20:51:13 Re: [HACKERS] UTF-32 support in PostgreSQL ?

Browse pgsql-jdbc by date

  From Date Subject
Next Message Shulgin, Oleksandr 2015-10-27 08:42:56 Re: Patch: Implement failover on libpq connect level.
Previous Message Peter Eisentraut 2015-10-26 20:28:28 Re: Patch (2): Implement failover on libpq connect level.