| From: | Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Antonin Houska <ah(at)cybertec(dot)at>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Robert Treat <rob(at)xzilla(dot)net> |
| Subject: | Re: Adding REPACK [concurrently] |
| Date: | 2026-04-04 13:16:58 |
| Message-ID: | CAFC+b6r23cpPBsxiJwDJGALkb6yCw=HwT0j0z1pHkyeCFBQbug@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Alvaro,
On Sat, Apr 4, 2026 at 1:01 AM Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
wrote:
> On 2026-Apr-03, Alvaro Herrera wrote:
>
> > - I polished the patch to reserve replication slots for REPACK. Given
> > the new implementation of 0006 that was submitted implies that we can
> > now run multiple repacks concurrently, I changed the default of 1 to 5.
>
> Srinath let me know that this new part was causing CI failures on
> Windows. This version v51 should be okay (or, at least, it passes for
> me on CI).
yes indeed , TotalMaxReplicationSlots was the culprit , as the window
after getting repack worked was forked , i think this was set back to 0.
Thanks for fixing this with "repack" flag , initially i thought why can't we
go with a macro
#define TotalMaxReplicationSlots (max_replication_slots +
max_repack_replication_slots)
but i thought maybe in future we might need this "repack" flag to add
more slot requirements.
--
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-04-04 13:25:26 | Re: Add pg_stat_autovacuum_priority |
| Previous Message | Álvaro Herrera | 2026-04-04 12:40:51 | Re: remove autoanalyze corner case |