| From: | Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com> |
|---|---|
| To: | Antonin Houska <ah(at)cybertec(dot)at> |
| Cc: | alvherre(at)kurilemu(dot)de, n(dot)kalinin(at)postgrespro(dot)ru, pgsql-bugs(at)lists(dot)postgresql(dot)org, b(at)ida(dot)kurilemu(dot)internal |
| Subject: | Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API |
| Date: | 2026-06-03 10:25:18 |
| Message-ID: | CAFC+b6qY8Jr1OkRqRX0KOy6-yauGwKTrw-OhQooYgzpyCwhgTA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Wed, Jun 3, 2026 at 1:00 PM Antonin Houska <ah(at)cybertec(dot)at> wrote:
> Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com> wrote:
>
> > Could we reject the pgrepack plugin at slot creation instead, in
> > pg_create_logical_replication_slot() and the CREATE_REPLICATION_SLOT
> > command, so misuse gets a clear "reserved for REPACK (CONCURRENTLY)"
> > error up front, before any decoding? REPACK creates its slot directly via
> > ReplicationSlotCreate(), so it's unaffected, and the begin-callback check
> > with magic guard can stay as the internal safety net.
> > Happy to be told this isn't worth special-casing :)
>
> Another possible approach: restrict the use of the plugin to the REPACK
> decoding worker.
>
cool ... that's cleaner, incorporated these changes and added test
,errcode.
--
Thanks :)
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0002-Reject-the-pgrepack-output-plugin-outside-REPACK-CON.patch | application/octet-stream | 4.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | 2026-06-03 16:22:53 | Fw: Re: heap_force_common in contrib/pg_surgery/heap_surgery.c has an off by one stack buffer overflow | |
| Previous Message | Antonin Houska | 2026-06-03 07:30:21 | Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API |