| From: | Antonin Houska <ah(at)cybertec(dot)at> |
|---|---|
| To: | Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com> |
| Cc: | alvherre(at)kurilemu(dot)de, n(dot)kalinin(at)postgrespro(dot)ru, pgsql-bugs(at)lists(dot)postgresql(dot)org, b(at)ida(dot)kurilemu(dot)internal |
| Subject: | Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API |
| Date: | 2026-06-03 07:30:21 |
| Message-ID: | 33766.1780471821@localhost |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com> wrote:
> Could we reject the pgrepack plugin at slot creation instead, in
> pg_create_logical_replication_slot() and the CREATE_REPLICATION_SLOT
> command, so misuse gets a clear "reserved for REPACK (CONCURRENTLY)"
> error up front, before any decoding? REPACK creates its slot directly via
> ReplicationSlotCreate(), so it's unaffected, and the begin-callback check
> with magic guard can stay as the internal safety net.
> Happy to be told this isn't worth special-casing :)
Another possible approach: restrict the use of the plugin to the REPACK
decoding worker.
--
Antonin Houska
Web: https://www.cybertec-postgresql.com
| Attachment | Content-Type | Size |
|---|---|---|
| repack_reserve_plugin_name.diff | text/x-diff | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Srinath Reddy Sadipiralla | 2026-06-03 10:25:18 | Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API |
| Previous Message | Srinath Reddy Sadipiralla | 2026-06-03 05:51:17 | Re: BUG #19500: pgrepack logical decoding plugin can crash assert builds via SQL decoding API |