Re: Adding REPACK [concurrently]

Hi Antonin,

On Mon, Mar 23, 2026 at 5:30 PM Antonin Houska <ah(at)cybertec(dot)at> wrote:

>
> I could not resist digging in it deeper :-) Attached is a test that
> reproduces
> the crash - it includes the isolation tester enhancement that I posted
> separately [1]. It crashes reliably with v43 [2] if your fix v43-0005 is
> omitted.
>

+1, i tested the same and yeah it reproduces the crash ,also reviewed
the patch LGTM, except i think you need to add this to makefile, so that a
simple
make check would be enough to run the isolation test, i think this all
makes sense
if this [1] patch goes in.

diff --git a/contrib/test_decoding/Makefile b/contrib/test_decoding/Makefile
index acbcaed2feb..201e3c84cb4 100644
--- a/contrib/test_decoding/Makefile
+++ b/contrib/test_decoding/Makefile
@@ -9,7 +9,10 @@ REGRESS = ddl xact rewrite toast permissions
decoding_in_xact \
ISOLATION = mxact delayed_startup ondisk_startup concurrent_ddl_dml \
oldest_xmin snapshot_transfer subxact_without_top concurrent_stream
\
twophase_snapshot slot_creation_error catalog_change_snapshot \
- skip_snapshot_restore invalidation_distribution
parallel_session_origin
+ skip_snapshot_restore invalidation_distribution
parallel_session_origin \
+ filtering
+
+EXTRA_INSTALL = src/test/modules/injection_points

REGRESS_OPTS = --temp-config
$(top_srcdir)/contrib/test_decoding/logical.conf
ISOLATION_OPTS = --temp-config
$(top_srcdir)/contrib/test_decoding/logical.conf

[1] - https://www.postgresql.org/message-id/flat/4703.1774250534%40localhost

--
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/