Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL

From: Srinath Reddy Sadipiralla <srinath2133(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: BharatDB <bharatdbpg(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL
Date: 2025-09-30 17:24:39
Message-ID: CAFC+b6oCjWxshOoq=8x+VEwcawYzruKn_FLLFzUxtsgPKe-ozg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Robert,

On Tue, Sep 30, 2025 at 8:08 PM Robert Haas <robertmhaas(at)gmail(dot)com> wrote:

> Hi,
>
> Please stop sending AI-generated messages that you haven't reviewed
> for accuracy. You now seem to be conflating what you did or didn't do
> with what Srinath did or didn't do.

+1

> Unless BharatDB/Soumya/manimurali
> is the same person as Srinath
>

no, i am the original Srinath (SrinathIsVerified) lol.

>
> The short version here is that this patch has no future because the
> entire premise of it is incorrect. There's no point in sending another
> version ever, as far as I can see. If you or anyone else disagrees, we
> should talk about that.
>

Can you please once confirm this, did you mean that this is not even an
actual problem to fix or only this patch's logic which I provided does
not make sense?, because i am trying out come up with another patch based
on your inputs regarding considering controlfile changes ,
ignoring RUNNING_XACTS records, and to use XLogRecGetRmid test.

--
Thanks,
Srinath Reddy Sadipiralla
EDB: https://www.enterprisedb.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2025-09-30 17:57:46 Re: Why cannot alter column type when a view depends on it?
Previous Message Tom Lane 2025-09-30 16:41:29 Re: The ability of postgres to determine loss of files of the main fork