| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Clean up optional rules in grammar |
| Date: | 2020-11-11 13:26:39 |
| Message-ID: | CAFBsxsGD6AaUDOXyWnE=p8W0Ex0On5CJTMDQZMQP6Ry3oU-+7A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Nov 11, 2020 at 5:13 AM Peter Eisentraut <
peter(dot)eisentraut(at)enterprisedb(dot)com> wrote:
> It's obviously confusing to have multiple different styles to do the
> same thing. And these extra rules (including the empty ones) also end
> up in the output, so they create more work down the line.
>
> The attached patch cleans this up to make them all look like the first
> style.
>
+1 for standardizing in this area. It's worth noting that Bison 3.0
introduced %empty for this situation, which is self-documenting. Until we
get there, this is a good step.
--
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2020-11-11 13:29:00 | Re: cutting down the TODO list thread |
| Previous Message | Greg Sabino Mullane | 2020-11-11 13:21:31 | Re: Prefer TG_TABLE_NAME over TG_RELNAME in tests |