| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Quan Zongliang <quanzongliang(at)yeah(dot)net> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Improving the heapgetpage function improves performance in common scenarios |
| Date: | 2023-09-06 09:07:37 |
| Message-ID: | CAFBsxsEsd-UtnvyCXWB3rEOxB17TJvdVMYgSB=3OWk3zOYi5FA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 6, 2023 at 2:50 PM Quan Zongliang <quanzongliang(at)yeah(dot)net>
wrote:
> If not optimized(--enable-debug CFLAGS='-O0'), there is a clear
> difference. When the compiler does the optimization, the performance is
> similar. I think the compiler does a good enough optimization with
> "pg_attribute_always_inline" and the last two constant parameters when
> calling heapgetpage_collect.
So as we might expect, more specialization (Andres' patch) has no apparent
downsides in this workload. (While I'm not sure of the point of testing at
-O0, I think we can conclude that less-bright compilers will show some
improvement with either patch.)
If you agree, do you want to withdraw your patch from the commit fest?
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-09-06 09:10:14 | Re: Introduce join_info_array for direct lookups of SpecialJoinInfo by ojrelid |
| Previous Message | Amit Kapila | 2023-09-06 08:55:47 | Re: [PoC] pg_upgrade: allow to upgrade publisher node |