From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: document pg_settings view doesn't display custom options |
Date: | 2020-10-30 17:06:56 |
Message-ID: | CAFBsxsErRSsukjnMK_iZwKfMNs5y96UR32MdA1vryt-4LogTBQ@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Oct 30, 2020 at 12:48 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> > Okay, along those lines here's a patch using "this view" in a new
> paragraph
> > for simplicity.
>
> Basically OK with me, but ...
>
> <quibble>
> It seems fairly weird to use a nonspecific reference first and then a
> specific one. That is, I'd expect to read "The pg_settings view ..."
> and then "This view ...", not the other way around. So we could
> put this para second, or put it first but make this para say
> "The pg_settings view ..." while the existing text gets reduced to
> "This view ...".
>
> Or just make them both say "This view ..." so we don't have to have
> this discussion again the next time somebody wants to add a para here.
> </quibble>
>
Okay, how's this?
--
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
v4-doc-pg-settings-no-custom.patch | application/octet-stream | 1.2 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | James Coleman | 2020-10-30 17:26:08 | Re: enable_incremental_sort changes query behavior |
Previous Message | Heikki Linnakangas | 2020-10-30 16:52:37 | Re: Parallel copy |