From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: document pg_settings view doesn't display custom options |
Date: | 2020-10-30 16:35:47 |
Message-ID: | CAFBsxsEj6cYvKUkkY3OBNS23t2u8_1bwBreC8yAMWMAikiUD+A@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Fri, Oct 30, 2020 at 12:07 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> > On Thu, Oct 29, 2020 at 11:51 PM Fujii Masao <
> masao(dot)fujii(at)oss(dot)nttdata(dot)com>
> > wrote:
> >> Also I think this note should be in the different paragraph from the
> >> paragraph
> >> of "The pg_settings view cannot be inserted into or deleted from...."
> >> because
> >> they are different topics. Thought?
>
> > Agreed on both points. In a separate paragraph, I think it's awkward to
> > start two consecutive sentences with "The pg_settings view". If we put it
> > in the previous paragraph we could phrase it like this:
>
> > "See Section 20.1 for more information about the various ways to change
> > these parameters. Customized options are not displayed until the
> > extension module that defines them has been loaded.
>
> That just moves the subject-inconsistency to a different para :-(
> I think this item should be its own new para.
>
> As for the repetitiveness, we could just say "This view ...", in one or
> even both paras.
>
Okay, along those lines here's a patch using "this view" in a new paragraph
for simplicity.
--
John Naylor
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Attachment | Content-Type | Size |
---|---|---|
v3-doc-pg-settings-no-custom.patch | application/octet-stream | 654 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2020-10-30 16:36:38 | Re: Parallel copy |
Previous Message | Anastasia Lubennikova | 2020-10-30 16:34:12 | Re: Corruption during WAL replay |