| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Japin Li <japinli(at)hotmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typo in pg_db_role_setting.h |
| Date: | 2022-08-01 12:46:30 |
| Message-ID: | CAFBsxsETpmZqWjLJw3gKjNg-dHUuR-+UnfoaBNhL4MoHJP1G3w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Aug 1, 2022 at 4:18 PM Japin Li <japinli(at)hotmail(dot)com> wrote:
>
>
> Hi, hackers
>
> I think there is a typo in pg_db_role_setting.h, should we fix it?
>
> diff --git a/src/include/catalog/pg_db_role_setting.h
b/src/include/catalog/pg_db_role_setting.h
> index 45d478e9e7..f92e867df4 100644
> /*
> - * prototypes for functions in pg_db_role_setting.h
> + * prototypes for functions in pg_db_role_setting.c
> */
You are correct, but I wonder if it'd be better to just drop the comment
entirely. I checked a couple other random headers with function
declarations and they didn't have such a comment, and it's kind of obvious
what they're for.
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2022-08-01 13:15:25 | Re: logical replication restrictions |
| Previous Message | John Naylor | 2022-08-01 12:38:05 | Re: NAMEDATALEN increase because of non-latin languages |