| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
| Cc: | Japin Li <japinli(at)hotmail(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Typo in pg_db_role_setting.h |
| Date: | 2022-08-01 14:16:08 |
| Message-ID: | 1707698.1659363368@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
John Naylor <john(dot)naylor(at)enterprisedb(dot)com> writes:
> You are correct, but I wonder if it'd be better to just drop the comment
> entirely. I checked a couple other random headers with function
> declarations and they didn't have such a comment, and it's kind of obvious
> what they're for.
Some places have these, some don't. It's probably more useful where
a header foo.h is declaring functions that aren't in the obviously
corresponding foo.c file, or live in multiple files. In this case
I agree it's not adding much.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David G. Johnston | 2022-08-01 14:20:37 | Re: Triggers should work in isolation, with a final conflict detection step |
| Previous Message | Zhang Mingli | 2022-08-01 13:56:14 | [feature]COPY FROM enable FORCE_NULL/FORCE_NOT_NULL on all columns |