| From: | John Naylor <john(dot)naylor(at)enterprisedb(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Steve Singer <steve(at)ssinger(dot)info>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: build remaining Flex files standalone |
| Date: | 2022-09-06 08:03:54 |
| Message-ID: | CAFBsxsENizUUJzemma4g+uTGt=sisuavju3Nk09vhitLwc-=Hg@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 5, 2022 at 1:18 AM Andres Freund <andres(at)anarazel(dot)de> wrote:
>
> Hi,
>
> On 2022-09-04 12:16:10 +0700, John Naylor wrote:
> > Pushed 01 and 02 separately, then squashed and pushed the rest.
>
> Thanks a lot! It does look a good bit cleaner to me now.
>
> I think, as a followup improvement, we should move gramparse.h to
> src/backend/parser, and stop installing gram.h, gramparse.h. gramparse.h
> already had this note:
>
> * NOTE: this file is only meant to be included in the core parsing files,
> * i.e., parser.c, gram.y, and scan.l.
> * Definitions that are needed outside the core parser should be in parser.h.
>
> What do you think?
+1 for the concept, but haven't looked at the details.
--
John Naylor
EDB: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Zhang Mingli | 2022-09-06 08:10:18 | Re: Out-of-date comments about RecentGlobalXmin? |
| Previous Message | Japin Li | 2022-09-06 08:03:32 | Out-of-date comments about RecentGlobalXmin? |