| From: | Zhang Mingli <zmlpostgres(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Japin Li <japinli(at)hotmail(dot)com> |
| Subject: | Re: Out-of-date comments about RecentGlobalXmin? |
| Date: | 2022-09-06 08:10:18 |
| Message-ID: | 8825bf24-dbb5-4e6c-91ff-f995b558f633@Spark |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Regards,
Zhang Mingli
On Sep 6, 2022, 16:03 +0800, Japin Li <japinli(at)hotmail(dot)com>, wrote:
>
> In commit dc7420c2c9, the RecentGlobalXmin variable is removed, however,
> there are some places that reference it.
>
> $ grep 'RecentGlobalXmin' -rn src/
> src/backend/replication/logical/launcher.c:101: * the secondary effect that it sets RecentGlobalXmin. (This is critical
> src/backend/utils/init/postinit.c:790: * interested in the secondary effect that it sets RecentGlobalXmin. (This
> src/backend/postmaster/autovacuum.c:1898: * the secondary effect that it sets RecentGlobalXmin. (This is critical
>
Yeah, RecentGlobalXmin is removed.
> It's out-of-date, doesn't it? I'm not sure s/RecentGlobalXmin/RecentXmin/g
> is right. Any thoughts?
I’m afraid not, RecentGlobalXmin is split to several GlobalVis* variables.
Need to check one by one.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-09-06 08:17:37 | Re: Out-of-date comments about RecentGlobalXmin? |
| Previous Message | John Naylor | 2022-09-06 08:03:54 | Re: build remaining Flex files standalone |