Re: Fix a typo in EnableLogicalDecoding()

Hi all,

On Thu, Sep 10, 2026 at 10:26 AM surya poondla <suryapoondla4(at)gmail(dot)com> wrote:
>
> Hi Chao, Shihao, Michael,
>
> Thank you for the patches, v2 patch looks good.
> Attached v3 is v2 with the below one additional change, it applies on its own.
>
> There is one more spot, in UpdateLogicalDecodingStatusEndOfRecovery where I felt the comment could be made more clear.
> "* ... On the other hand, we need to wait for synchronizing
> * XLogLogicalInfo even if we've not updated the status above as the
> * status have been turned on and off during recovery, having running
> * processes have different status on their local caches."
>
> Updated the above in v3 as
> "* ... On the other hand, we need to wait for XLogLogicalInfo to be
> * synchronized even if we've not updated the status above, as the
> * status may have been turned on and off during recovery, leaving
> * running processes with different values in their local caches."
>
> I'm not sure if this reword is worth the churn, happy to drop it if you'd rather keep the original wording.
>

Thank you for the updated patch. I reviewed the patch and went through
the changes in src/backend/replication/logical/logicalctl.c. I agree
with the corrections made so far. The additional typo fixes in v2
patch looks correct to me too, and also I agree with the revised
wording in UpdateLogicalDecodingStatusEndOfRecovery(), which seems
more clearer and easier to understand. The patch applies cleanly to my
tree, and I confirmed that the changes are limited to comments and do
not alter the code behavior.

Regards,
Solai