| From: | surya poondla <suryapoondla4(at)gmail(dot)com> |
|---|---|
| To: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, zhong950419(at)gmail(dot)com |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz> |
| Subject: | Re: Fix a typo in EnableLogicalDecoding() |
| Date: | 2026-09-03 18:45:03 |
| Message-ID: | CAOVWO5rpADKKPGrJd7MQRPy6vxpmWBvbfzhH7+qsYuwmXRjxeA@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Chao, Shihao, Michael,
Thank you for the patches, v2 patch looks good.
Attached v3 is v2 with the below one additional change, it applies on its
own.
There is one more spot, in UpdateLogicalDecodingStatusEndOfRecovery where I
felt the comment could be made more clear.
"* ... On the other hand, we need to wait for synchronizing
* XLogLogicalInfo even if we've not updated the status above as the
* status have been turned on and off during recovery, having running
* processes have different status on their local caches."
Updated the above in v3 as
"* ... On the other hand, we need to wait for XLogLogicalInfo to be
* synchronized even if we've not updated the status above, as the
* status may have been turned on and off during recovery, leaving
* running processes with different values in their local caches."
I'm not sure if this reword is worth the churn, happy to drop it if you'd
rather keep the original wording.
Regards,
Surya Poondla
| Attachment | Content-Type | Size |
|---|---|---|
| v3-0001-Fix-typos-in-logicalctl.c-comments.patch | application/octet-stream | 3.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Lakhin | 2026-09-03 19:00:00 | Re: Stabilize recovery conflict stats checks in 031_recovery_conflict.pl |
| Previous Message | Nathan Bossart | 2026-09-03 18:42:09 | Re: Remove fcinfo from statistics update internal functions |