| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Remove PG_MMAP_FLAGS |
| Date: | 2026-01-22 17:22:08 |
| Message-ID: | CAExHW5vTWABxuM5fbQcFkGuTLwaxuZDEE2vtx2WuMUWk6JnF4g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Over [1] Peter mentioned that PG_MMAP_FLAGS is not used for
portability even though it's placed in portability/mem.h. That might
have been the intention when it was added in
b0fc0df9364d2d2d17c0162cf3b8b59f6cb09f67. But history does not show it
being used that way at any point in time. Per suggestion removing that
macro and instead using the flags directly in CreateAnonymousSegment()
which is the only place where it's used.
PFA patch for the same.
--
Best Wishes,
Ashutosh Bapat
| Attachment | Content-Type | Size |
|---|---|---|
| v20260112-0001-Fix-PGShmemType-and-HugePagesType-typedefs.patch | text/x-patch | 1.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sami Imseih | 2026-01-22 17:23:29 | Re: Flush some statistics within running transactions |
| Previous Message | Ilyasov Ian | 2026-01-22 17:07:19 | RE: ReadRecentBuffer() doesn't scale well |