| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Subject: | Re: Remove PG_MMAP_FLAGS |
| Date: | 2026-01-22 19:17:08 |
| Message-ID: | 2772065.1769109428@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> writes:
> Over [1] Peter mentioned that PG_MMAP_FLAGS is not used for
> portability even though it's placed in portability/mem.h. That might
> have been the intention when it was added in
> b0fc0df9364d2d2d17c0162cf3b8b59f6cb09f67. But history does not show it
> being used that way at any point in time. Per suggestion removing that
> macro and instead using the flags directly in CreateAnonymousSegment()
> which is the only place where it's used.
I think you attached the wrong patch? This one doesn't touch
PG_MMAP_FLAGS.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Jones | 2026-01-22 19:27:11 | Re: ALTER TABLE: warn when actions do not recurse to partitions |
| Previous Message | Álvaro Herrera | 2026-01-22 18:58:05 | Re: Race conditions in logical decoding |