| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Jelte Fennema-Nio <me(at)jeltef(dot)nl> |
| Cc: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Proposal: Make cfbot fail on patches not created by "git format-patch" |
| Date: | 2025-05-30 04:18:52 |
| Message-ID: | CAExHW5v2P6_LT6qyxrOKzT2D9hr01tGdqgVYPPHVzXkcJ_3GiA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, May 16, 2025 at 1:45 PM Jelte Fennema-Nio <me(at)jeltef(dot)nl> wrote:
> On Fri, 16 May 2025 at 12:24, Jacob Champion
> <jacob(dot)champion(at)enterprisedb(dot)com> wrote:
> >
> > On Fri, May 16, 2025 at 12:12 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > > That outcome seems entirely horrible to me. If you want to flag the
> lack
> > > of a commit message somehow, fine, but don't prevent CI from running.
> >
> > Personally I also prefer nudges to gates.
>
> Okay, reasonable feedback. How about we add a CI job that does a
> "quality check". That's much less strong, as all the other tests will
> still run, but people would get a failing CI job which tells them that
> something is wrong. We could also include a pgindent in that CI job.
>
>
> +1. Knowing whether to use git am or patch to apply the patch itself will
save reviewers' time.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Hayato Kuroda (Fujitsu) | 2025-05-30 04:26:47 | RE: [PATCH] Proposal: Improvements to PDF stylesheet and table column widths |
| Previous Message | Peter Smith | 2025-05-30 01:38:20 | Re: [WIP]Vertical Clustered Index (columnar store extension) - take2 |