Re: [PATCH TEST] Fix logical replication setup in subscription test `t/009_matviews.pl`

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
Cc: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Грем Снорт <grem(dot)snoort(at)gmail(dot)com>
Subject: Re: [PATCH TEST] Fix logical replication setup in subscription test `t/009_matviews.pl`
Date: 2025-10-13 12:42:07
Message-ID: CAExHW5ukkOcPM2_uSjXGsEf1QjqgdUDyc_b4Q+we-PX61jcXaw@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 13, 2025 at 5:18 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Sun, Oct 12, 2025 at 11:29 AM Hayato Kuroda (Fujitsu)
> <kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
> >
> > Dear Amit, Ashutosh,
> >
> > > Thanks for the analysis. I think we should go with the simple patch
> > > proposed in this thread to improve this test and that too only for
> > > HEAD.
> >
> > To confirm, are you suggesting something like attached? It initially creates MVs
> > on both instances, then ensure REFRESH MATERIALIZED VIEW won't be replicated.
> > It also fixed the issue reported by Грем.
> >
>
> What difference REFRESH will make instead of CREATE? I think it is
> okay to just patch what is posted by the reporter in the first email
> [1] in this thread.
>
> [1]: https://www.postgresql.org/message-id/CANV9Qw5HD7%3DFp4nox2O7DoVctHoabRRVW9Soo4A%3DQipqW5B%3DTg%40mail.gmail.com

For now this makes sense.

We could avoid running a full test, and save time and resources, if we
piggy back MV vs logical replication testing on 100_bugs.pl. If we do
that, it should be master-only and can be a separate discussion.

--
Best Wishes,
Ashutosh Bapat

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Nazir Bilal Yavuz 2025-10-13 12:49:01 Upgrade Debian CI image from Bookworm to Trixie
Previous Message Robert Haas 2025-10-13 12:32:07 Re: another autovacuum scheduling thread