Re: anonymous unions (C11)

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: anonymous unions (C11)
Date: 2025-09-30 14:41:08
Message-ID: CAExHW5tcypg4JV0mrcZXCKUFMgQbkOtTNu1iSe8uOqDBW=+ODg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Sep 30, 2025 at 5:14 PM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2025-Sep-30, Ashutosh Bapat wrote:
>
> > Attached patch fixes those errors for me.
>
> > diff --git a/src/common/cryptohash.c b/src/common/cryptohash.c
> > index fc0555d2f99..e8a35c2ec35 100644
> > --- a/src/common/cryptohash.c
> > +++ b/src/common/cryptohash.c
> > @@ -61,7 +61,7 @@ struct pg_cryptohash_ctx
> > pg_sha256_ctx sha256;
> > pg_sha384_ctx sha384;
> > pg_sha512_ctx sha512;
> > - } data;
> > + };
> > };
>
> Isn't this patch 0015 in Peter's series?

I found the compilation errors after pulling the latest sources at
that time. I thought the patch series is committed and hence this
report and patch. Didn't look at the patch series.

But the problematic commit has been reverted since then.

--
Best Wishes,
Ashutosh Bapat

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Álvaro Herrera 2025-09-30 14:48:00 Re: allow benign typedef redefinitions (C11)
Previous Message Robert Haas 2025-09-30 14:38:38 Re: [PATCH] Fix pg_rewind false positives caused by shutdown-only WAL