| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | vignesh C <vignesh21(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_decode_message vs skip_empty_xacts and xact_wrote_changes |
| Date: | 2023-07-05 13:50:06 |
| Message-ID: | CAExHW5tcfvvwrKP4TtHFetBd0mc3CPpjsSDbjz3HYQJCcGc4JA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jul 5, 2023 at 2:29 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
>
> On Wed, Jul 5, 2023 at 2:28 PM Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> >
> > On Mon, Jul 3, 2023 at 4:49 PM vignesh C <vignesh21(at)gmail(dot)com> wrote:
> > >
> > > +1 for the first version patch, I also felt the first version is
> > > easily understandable.
> > >
> >
> > Okay, please find the slightly updated version (changed a comment and
> > commit message). Unless there are more comments, I'll push this in a
> > day or two.
> >
>
> oops, forgot to attach the patch.
I still think that we need to do something so that a new call to
pg_output_begin() automatically takes care of the conditions under
which it should be called. Otherwise, we will introduce a similar
problem in some other place in future.
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Euler Taveira | 2023-07-05 14:01:08 | Re: Allow specifying a dbname in pg_basebackup connection string |
| Previous Message | Aleksander Alekseev | 2023-07-05 13:45:49 | Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15) |