Re: [PATCH] regression test: view and rule definitions must round trip

From: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
To: Greg Burd <greg(at)burd(dot)me>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] regression test: view and rule definitions must round trip
Date: 2026-10-26 18:56:25
Message-ID: CAExHW5sLxc9ABCWm1J3Xp440pew=_29kiuJ_0nyfxTd4L9PAYg@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Oct 26, 2026 at 7:43 PM Greg Burd <greg(at)burd(dot)me> wrote:
> > >AFAICT, there's no
> > > single test that says "take this whole corpus of known-nasty shapes and
> > > assert the round-trip property for every one."
... snip ...
>
> I'm not sure what you're suggesting, yes that is true but does that mean
> that you'd prefer that method for validation over what I've proposed?
>

I am simply pointing out that a test which you said doesn't exist
above. I would rather use that infrastructure (which works for objects
other than views as well) that creating a new one specifically for
views. If we could build a better way to do this for all objects, that
would be great. That possibility has been discussed earlier.

> > Are the views testing the features above left behind by the testcase
> > or dropped?
>
> They are in a schema and removed at the end of the test.

That explains why we missed catching those bugs when they were added.

--
Best Wishes,
Ashutosh Bapat

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Manu 2026-10-26 19:02:25 Re: Do we need an index on pg_constraint.confrelid?
Previous Message Aidar Imamov 2026-10-26 18:45:20 Re: meson: pass OpenSSL/ICU include dirs to extensions