| From: | Aidar Imamov <imamovaj22(at)gmail(dot)com> |
|---|---|
| To: | Harrison Booth <harrisontbooth(at)gmail(dot)com> |
| Cc: | ju(dot)grigorev(at)ftdata(dot)ru, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: meson: pass OpenSSL/ICU include dirs to extensions |
| Date: | 2026-10-26 18:45:20 |
| Message-ID: | 51772BEC-C2DD-4C51-9E66-B9B2E92D2C9B@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
v6 attached.
I left your patch 1 as it was, apart from a comment.
I had first simplified the string/array handling to ';'.join([] + incdirs), but
Meson 0.57.2 rejects list + string with plain +, only += accepts it,
so your two-line version is the one that works. I caught that by
forcing the CMake fallback on both 0.57.2 and 1.7: both now produce the
right -I flags.
Regards,
Aidar Imamov
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-meson-expose-OpenSSL-and-ICU-compiler-flags-to-PG.patch | application/octet-stream | 8.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashutosh Bapat | 2026-10-26 18:56:25 | Re: [PATCH] regression test: view and rule definitions must round trip |
| Previous Message | Greg Burd | 2026-10-26 18:43:06 | Re: [PATCH] regression test: view and rule definitions must round trip |