| From: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
|---|---|
| To: | Euler Taveira <euler(at)eulerto(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: speed up a logical replica setup |
| Date: | 2023-10-26 11:47:23 |
| Message-ID: | CAExHW5sCAU3NvPKd7msScQKvrBN-x_AdDQD-ZYAwOxuWG=oz1w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 23, 2023 at 9:34 AM Euler Taveira <euler(at)eulerto(dot)com> wrote:
>
> It is still a WIP but I would like to share it and get some feedback.
>
>
I have started reviewing the patch. I have just read through all the
code. It's well documented and clear. Next I will review the design in
detail. Here are a couple of minor comments
1.
+tests += {
+ 'name': 'pg_subscriber',
+ 'sd': meson.current_source_dir(),
+ 'bd': meson.current_build_dir(),
+ 'tap': {
+ 'tests': [
+ 't/001_basic.pl',
COMMENT
Shouldn't we include 002_standby.pl?
2. CreateReplicationSlotLSN, is not used anywhere. Instead I see
create_logical_replication_slot() in pg_subscriber.c. Which of these
two you intend to use finally?
--
Best Wishes,
Ashutosh Bapat
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Aleksander Alekseev | 2023-10-26 12:04:52 | Re: RFC: Pluggable TOAST |
| Previous Message | Nikita Malakhov | 2023-10-26 11:29:51 | Re: RFC: Pluggable TOAST |