| From: | lakshmi <lakshmigcdac(at)gmail(dot)com> |
|---|---|
| To: | Dmitrii Bondar <d(dot)bondar(at)postgrespro(dot)ru> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Pgbench: remove synchronous prepare |
| Date: | 2026-04-16 12:10:32 |
| Message-ID: | CAEvyyTgeUC_FWrfy5Vpz9RrZ2L74Yv1B+yK8xs-8+VjgTJtz9g@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Dmitrii,
Yes, my review is complete. The patch works well in my testing and resolves
the blocking issue without any regressions.
You can move it to 'Ready for Committer.'
Regards,
Lakshmi G
On Thu, Apr 16, 2026 at 12:45 PM Dmitrii Bondar <d(dot)bondar(at)postgrespro(dot)ru>
wrote:
> Hi!
>
> Thank you for reviewing my patch! Should I consider your review complete
> and move the patch to ‘ready for committer’?
> On 4/6/26 1:54 PM, lakshmi wrote:
>
>
> On Mon, Mar 23, 2026 at 11:45 AM Dmitrii Bondar <d(dot)bondar(at)postgrespro(dot)ru>
> wrote:
>
>> Rebase.
>>
>> Hi Dmitrii,
>>
>> I tested the latest patch with PgBouncer in session pooling mode (pool
>> size 20, 21 clients).
>>
>> Before applying the patch, pgbench got stuck under this setup and
>> eventually hit a query_wait_timeout error.
>>
>> After applying the patch, pgbench runs smoothly even when clients are
>> queued. I can see continuous progress output and normal throughput (~60k
>> TPS), with no errors or stalls.
>>
>> The change works well in my testing.
>>
>> Thanks for the patch!
>>
>> Regards,
>> Lakshmi G
>>
>>
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amul Sul | 2026-04-16 12:30:38 | Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid |
| Previous Message | Bertrand Drouvot | 2026-04-16 11:31:27 | Re: Make copyObject work in C++ |