Re: [PATCH] Windows port, fix some resources leaks

Em ter., 28 de jan. de 2020 às 17:54, Robert Haas <robertmhaas(at)gmail(dot)com>
escreveu:

> On Fri, Jan 24, 2020 at 2:13 AM Michael Paquier <michael(at)paquier(dot)xyz>
> wrote:
> > No, that's not right. I think that it is possible to loop over
> > ShmemProtectiveRegion in some cases. And actually, your patch is dead
> > wrong because this is some code called by the postmaster and it cannot
> > use FATAL.
>
> Uh, really? I am not aware of such a rule.
>
> Well, in postmaster.c has a structure that makes use of the variable
ShmemProtectiveRegion, I think it is related to the function in
src/backend/port/win32_shmem.c.
On line 575 in src / backend / port / win32_shmem.c, there is a comment
that tells to not use FATAL.
"Don't use FATAL since we're running in the postmaster."

regards,
Ranier Vilela