| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Windows port, fix some resources leaks |
| Date: | 2020-01-28 21:06:17 |
| Message-ID: | 20200128210617.GA10415@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-Jan-28, Robert Haas wrote:
> On Fri, Jan 24, 2020 at 2:13 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> > No, that's not right. I think that it is possible to loop over
> > ShmemProtectiveRegion in some cases. And actually, your patch is dead
> > wrong because this is some code called by the postmaster and it cannot
> > use FATAL.
>
> Uh, really? I am not aware of such a rule.
I don't think we have ever expressed it as such, but certainly we prefer
postmaster to be super robust ... rather live with a some hundred bytes
leak rather than have it die and take the whole database service down
for what's essentially a fringe bug that has bothered no one in a decade
and a half.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ranier Vilela | 2020-01-28 21:08:17 | Re: [PATCH] Windows port, fix some resources leaks |
| Previous Message | Tom Lane | 2020-01-28 21:00:35 | Re: VALUES ROW(...) |