Quick Links

[PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)

From:	Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
To:	Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject:	[PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Date:	2022-02-09 10:56:35
Message-ID:	CAEudQApq+wJJyFHQ9iYGrd2vUK+Uk1i214KsBewe7nkvcWYBaQ@mail.gmail.com
Views:	Raw Message \| Whole Thread \| Download mbox \| Resend email
Thread:
Lists:	pgsql-hackers

Hi,

I think this change can improve this particular function by avoiding
touching value if not needed.
Test if not isnull is cheaper than test TupleDescAttr is -1.

best regards,

Ranier Vilela

Attachment	Content-Type	Size
v1_tiny_improvemnt_toast_helper.patch	application/octet-stream	719 bytes

Responses

Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c) at 2022-02-09 13:52:30 from Julien Rouhaud
Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c) at 2022-02-09 14:33:47 from Dong Wook Lee

Browse pgsql-hackers by date

	From	Date	Subject
Next Message	Ranier Vilela	2022-02-09 11:15:45	Possible uninitialized use of the variables (src/backend/access/transam/twophase.c)
Previous Message	Dilip Kumar	2022-02-09 10:25:20	Re: Make relfile tombstone files conditional on WAL level