Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: Ranier Vilela <ranier(dot)vf(at)gmail(dot)com>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Improve function toast_delete_external (src/backend/access/table/toast_helper.c)
Date: 2022-02-09 13:52:30
Message-ID: 20220209135230.yd4nsgxwvmltpude@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On Wed, Feb 09, 2022 at 07:56:35AM -0300, Ranier Vilela wrote:
>
> I think this change can improve this particular function by avoiding
> touching value if not needed.
> Test if not isnull is cheaper than test TupleDescAttr is -1.

It looks sensible.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2022-02-09 14:01:36 Replacing TAP test planning with done_testing()
Previous Message Bernd Helmle 2022-02-09 13:50:58 Re: is the base backup protocol used by out-of-core tools?