| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Refactor to eliminate cast-away-const in pg_dump object sort comparator |
| Date: | 2025-12-24 01:58:32 |
| Message-ID: | CAEoWx2nN3LYhBmDBaXDoZ=+ikNJkJT7vzg+xPYsHUTSkV8unvg@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Hacker,
While reviewing patch [1], I raised a comment about cast-away-const in
pg_dump_sort.c. However, the comment was not accepted and the argument was
that the nearby code did the same thing.
I saw Tom recently had a commit [2] that removed some cast-away-const in
ecpg, so I am filing this patch to eliminate all cast-away-const problems
in pg_dump_sort.c.
[1]
https://postgr.es/m/CALDaNm2x3rd7C0_HjUpJFbxpAqXgm=QtoKfkEWDVA8h+JFpa_w@mail.gmail.com
[2]
https://git.postgresql.org/cgit/postgresql.git/commit/?id=4eda42e8bdf5bd3bf69576d54a45c10e7cbc3b35
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Refactor-to-eliminate-cast-away-const-in-pg_dump-.patch | application/octet-stream | 7.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2025-12-24 02:17:56 | Fix incorrect buffer lock description in pg_visibility comment |
| Previous Message | Bruce Momjian | 2025-12-24 01:36:06 | Re: [PATCH] Fix typo in psql \copy command documentation |