| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Fix incorrect buffer lock description in pg_visibility comment |
| Date: | 2025-12-24 02:17:56 |
| Message-ID: | CAEoWx2kkhxgfp=kinPMetnwHaa0JjR6YBkO_0gg0oiy6mu7Zjw@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Hackers,
While reviewing the patch [1], though I couldn’t raise a comment for it, I
noticed a comment error in the file pg_visibility.c, where a buffer lock is
held in shared mode but the code comment mentioned exclusive mode. I am
filing a small patch to correct the comment.
I only changed "exclusively" to "shared", the format changed was done by
pgindent.
[1]
https://postgr.es/m/CAEze2WgPu-EYYuYQimy=AHQHGa7w8EvLVve5DM5eGMR6zh-7sw@mail.gmail.com
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Fix-incorrect-buffer-lock-description-in-pg_visib.patch | application/octet-stream | 1.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2025-12-24 02:47:55 | Re: More const-marking cleanup |
| Previous Message | Chao Li | 2025-12-24 01:58:32 | Refactor to eliminate cast-away-const in pg_dump object sort comparator |