| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | milyutinma(at)gmail(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Typo in description of replay_lag attribute in pg_stat_replication view |
| Date: | 2018-12-04 00:28:15 |
| Message-ID: | CAEepm=3rVm=krEhefk-o=e4KTG3ry_QMJWcn7DgFSGbOc4_UYQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-docs |
On Tue, Dec 4, 2018 at 1:18 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Mon, Dec 03, 2018 at 06:18:30PM +0300, Maksim Milyutin wrote:
> > I have noticed that in description of *flush_lag* in pg_stat_replication
> > view (https://www.postgresql.org/docs/current/monitoring-stats.html#PG-STAT-REPLICATION-VIEW)
> > there exists unknown value of synchronous_commit parameter - *remote_flush*.
> > I think it was meant to use the value *on*.
>
> Yes, you are right. It should be "on" as "remote_flush" is not a valid
> value. remote_flush is listed in SyncCommitLevel though, so this makes
> me wonder if we should also introduce a new value for this purpose
> available for users. The fix you propose looks good to me. Any
> opinions from others?
+1 for the patch.
As for introducing remote_flush as the true name of the level, this
was discussed but somehow went off-course and never made it to the
finish line:
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2018-12-04 02:19:25 | Re: Typo in description of replay_lag attribute in pg_stat_replication view |
| Previous Message | Michael Paquier | 2018-12-04 00:18:02 | Re: Typo in description of replay_lag attribute in pg_stat_replication view |