Re: Supporting huge pages on Windows

On Thu, Jan 5, 2017 at 4:12 PM, Tsunakawa, Takayuki
<tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> wrote:
> [win_large_pages_v4.patch]

Just a small suggestion about the wording in this patch:

+ This feature uses the large-page support on Windows. To use
the large-page
+ support, you need to assign Lock page in memory user right to
the Windows
+ user account which runs <productname>PostgreSQL</productname>.

In the Microsoft documentation I've seen, the privilege's name is
always written as "Lock Pages in Memory" (note: "Pages" plural, and
with initial capital letters). It's quite hard to parse the sentence
otherwise! How about this?

Huge pages are known as large pages on Windows. To use them,
you need to
assign the user right Lock Pages in Memory to the Windows user account
that runs <productname>PostgreSQL</productname>.

+ ereport(elevel,
+ (errmsg("could not enable Lock pages in memory user right: error
code %lu", GetLastError()),
+ errdetail("Failed system call was OpenProcessToken.")));

Same comment about capitalisation of the privilege name in this and
other error messages.

--
Thomas Munro
http://www.enterprisedb.com