| From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> | 
|---|---|
| To: | 'Thomas Munro' <thomas(dot)munro(at)enterprisedb(dot)com> | 
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> | 
| Subject: | Re: Supporting huge pages on Windows | 
| Date: | 2017-01-06 03:01:57 | 
| Message-ID: | 0A3221C70F24FB45833433255569204D1F6712DF@G01JPEXMBYT05 | 
| Views: | Whole Thread | Raw Message | Download mbox | Resend email | 
| Thread: | |
| Lists: | pgsql-hackers | 
From: Thomas Munro [mailto:thomas(dot)munro(at)enterprisedb(dot)com]
> In the Microsoft documentation I've seen, the privilege's name is always
> written as "Lock Pages in Memory" (note: "Pages" plural, and with initial
> capital letters).  It's quite hard to parse the sentence otherwise!  How
> about this?
> 
>          Huge pages are known as large pages on Windows.  To use them, you
> need to
>          assign the user right Lock Pages in Memory to the Windows user
> account
>          that runs <productname>PostgreSQL</productname>.
> 
> + ereport(elevel,
> + (errmsg("could not enable Lock pages in memory user right: error
> code %lu", GetLastError()),
> + errdetail("Failed system call was OpenProcessToken.")));
> 
> Same comment about capitalisation of the privilege name in this and other
> error messages.
Thanks, your sentences are surely better. Fixed.
Regards
Takayuki Tsunakawa
| Attachment | Content-Type | Size | 
|---|---|---|
| win_large_pages_v5.patch | application/octet-stream | 6.9 KB | 
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Gierth | 2017-01-06 03:48:58 | Hash support for grouping sets | 
| Previous Message | Bruce Momjian | 2017-01-06 02:59:27 | Re: pg_stat_activity.waiting_start |