| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Haribabu Kommi <kommi(dot)haribabu(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: [[Parallel] Shared] Hash |
| Date: | 2017-01-03 09:53:43 |
| Message-ID: | CAEepm=1OuKD1dPw_CRapPf5PQnUW3v2EdNf0bXmx6BzCFCMRow@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jan 2, 2017 at 3:17 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> I noticed a bug in your latest revision:
>
>> + /*
>> + * In HJ_NEED_NEW_OUTER, we already selected the current inner batch for
>> + * reading from. If there is a shared hash table, we may have already
>> + * partially loaded the hash table in ExecHashJoinPreloadNextBatch.
>> + */
>> + Assert(hashtable->batch_reader.batchno = curbatch);
>> + Assert(hashtable->batch_reader.inner);
>
> Obviously this isn't supposed to be an assignment.
Right, thanks! I will post a new rebased version soon with that and
some other nearby problems fixed.
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Rajkumar Raghuwanshi | 2017-01-03 10:04:43 | Re: Declarative partitioning - another take |
| Previous Message | Craig Ringer | 2017-01-03 09:20:53 | Re: Logical decoding - filtering tables |