| From: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> |
|---|---|
| To: | Michail Nikolaev <michail(dot)nikolaev(at)gmail(dot)com> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] fix for C4141 warning on MSVC |
| Date: | 2018-01-24 00:31:20 |
| Message-ID: | CAEepm=1AOYEhYZ2NRow8A7FCrRgy-6a=8h=8FnZRWbZ1P_YZuA@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 24, 2018 at 1:16 PM, Michail Nikolaev
<michail(dot)nikolaev(at)gmail(dot)com> wrote:
> Just very small fix for C4141 warning
> (https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-1-c4141).
>
> Also could be viewed on Github -
> https://github.com/michail-nikolaev/postgres/commit/38a590a00110a4ea870d625470e4c898e5ad79aa
>
> Tested both MSVC and gcc builds.
Thanks. This is similar to the fix I proposed over here:
Two differences:
1. I also fixed a warning from antique GCC which didn't understand this magic.
2. You also defined it as plain old "inline" for unknown compilers.
Perhaps we should combine these?
--
Thomas Munro
http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2018-01-24 00:34:38 | Re: Missing wal_receiver_status_interval in Subscribers section |
| Previous Message | Michail Nikolaev | 2018-01-24 00:16:38 | [PATCH] fix for C4141 warning on MSVC |