Re: pgsql: hash: Add write-ahead logging support.

On Wed, Mar 15, 2017 at 3:23 PM, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote:
> On Tue, Mar 14, 2017 at 11:26 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Tue, Mar 14, 2017 at 1:54 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>>>> hash: Add write-ahead logging support.
>>>
>>> This bit in access/hash/README, lines 368ff, appears obsolete:
>>>
>>> Although we can survive a failure to split a bucket, a crash is likely to
>>> corrupt the index, since hash indexes are not yet WAL-logged.
>>>
>>> Perhaps we can just delete that para. If not, what should it say now?
>>
>> That's obsolete, and can just be removed.
>>
>
> Agreed and posted a patch on hackers [1]

Also the obsolete warning message appears in .po files and the mb tests:

$ git grep 'and their use is discouraged'
src/backend/po/de.po:msgid "hash indexes are not WAL-logged and their
use is discouraged"
src/backend/po/es.po:msgid "hash indexes are not WAL-logged and their
use is discouraged"
src/backend/po/fr.po:msgid "hash indexes are not WAL-logged and their
use is discouraged"
src/backend/po/it.po:msgid "hash indexes are not WAL-logged and their
use is discouraged"
src/backend/po/pl.po:msgid "hash indexes are not WAL-logged and their
use is discouraged"
src/backend/po/ru.po:msgid "hash indexes are not WAL-logged and their
use is discouraged"
src/backend/po/zh_CN.po:msgid "hash indexes are not WAL-logged and
their use is discouraged"
src/test/mb/expected/big5.out:WARNING: hash indexes are not
WAL-logged and their use is discouraged
src/test/mb/expected/euc_jp.out:WARNING: hash indexes are not
WAL-logged and their use is discouraged
src/test/mb/expected/euc_kr.out:WARNING: hash indexes are not
WAL-logged and their use is discouraged
src/test/mb/expected/euc_tw.out:WARNING: hash indexes are not
WAL-logged and their use is discouraged
src/test/mb/expected/gb18030.out:WARNING: hash indexes are not
WAL-logged and their use is discouraged
src/test/mb/expected/mule_internal.out:WARNING: hash indexes are not
WAL-logged and their use is discouraged
src/test/mb/expected/mule_internal.out:WARNING: hash indexes are not
WAL-logged and their use is discouraged
src/test/mb/expected/sjis.out:WARNING: hash indexes are not
WAL-logged and their use is discouraged
src/test/mb/expected/utf8.out:WARNING: hash indexes are not
WAL-logged and their use is discouraged

--
Thomas Munro
http://www.enterprisedb.com