Re: pgsql: hash: Add write-ahead logging support.

From: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: hash: Add write-ahead logging support.
Date: 2017-03-15 02:23:49
Message-ID: CAA4eK1+wfDRUpob2eyLdTNx73HerFmcw7VCkr4AL1+ZYt7qHHQ@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Tue, Mar 14, 2017 at 11:26 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> On Tue, Mar 14, 2017 at 1:54 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Robert Haas <rhaas(at)postgresql(dot)org> writes:
>>> hash: Add write-ahead logging support.
>>
>> This bit in access/hash/README, lines 368ff, appears obsolete:
>>
>> Although we can survive a failure to split a bucket, a crash is likely to
>> corrupt the index, since hash indexes are not yet WAL-logged.
>>
>> Perhaps we can just delete that para. If not, what should it say now?
>
> That's obsolete, and can just be removed.
>

Agreed and posted a patch on hackers [1]

[1] - https://www.postgresql.org/message-id/CAA4eK1LeVu8rSvA%3DhfbezqjNv5x3nU-rPbHCHHbbsCrLX-0zAg%40mail.gmail.com

--
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2017-03-15 02:35:29 Re: pgsql: hash: Add write-ahead logging support.
Previous Message Andrew Dunstan 2017-03-15 00:29:04 Re: [COMMITTERS] pgsql: Use asynchronous connect API in libpqwalreceiver