Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity

From: Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>
Subject: Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity
Date: 2018-01-03 23:31:41
Message-ID: CAEepm=0v4FMpwroEjSWHVcigpr4SWcBhS0SJm57+eM5P=Ax02Q@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Jan 4, 2018 at 12:29 PM, Thomas Munro
<thomas(dot)munro(at)enterprisedb(dot)com> wrote:
> If there is any system where sizeof(FormData_pg_attribute) !=
> (offsetof(FormData_pg_attribute,attcollation) + sizeof(Oid)), won't
> load_relcache_init_file() get upset? Oh, I see it would just go to
> read_failed and then "do it the hard way".

This doesn't make any sense, we're free to change that file format in
a major release anyway. I withdraw that comment!

--
Thomas Munro
http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2018-01-03 23:36:07 Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity
Previous Message Thomas Munro 2018-01-03 23:29:05 Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity